Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove --turbo dev flag #1722

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(core): remove --turbo dev flag #1722

merged 1 commit into from
Dec 9, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

The --turbo flag is causing a few issue as it's still experimental. Opting to remove it for now.

Testing

Screenshot 2024-12-09 at 16 30 54

@chanceaclark chanceaclark requested a review from a team as a code owner December 9, 2024 21:31
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 523a6dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:33pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:33pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 9, 2024 9:33pm
catalyst-au ⬜️ Ignored (Inspect) Dec 9, 2024 9:33pm
catalyst-uk ⬜️ Ignored (Inspect) Dec 9, 2024 9:33pm

@chanceaclark chanceaclark added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 1f0c2ef Dec 9, 2024
13 of 15 checks passed
@chanceaclark chanceaclark deleted the fix/remove-turbo branch December 9, 2024 21:35
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-p87n4067v-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants