Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update add to cart visual errors #1674

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Updates the add to cart actions to show an error based on the API response.

Testing

Screenshot 2024-11-21 at 13 59 06

@chanceaclark chanceaclark requested a review from a team as a code owner November 21, 2024 18:59
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 7:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 22, 2024 7:59pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 7:59pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 7:59pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 7:59pm

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 0b32580

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chanceaclark chanceaclark force-pushed the fix/inventory-handling branch from 4da5cc4 to 0b32580 Compare November 22, 2024 19:56
@chanceaclark chanceaclark added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 512c338 Nov 22, 2024
10 of 11 checks passed
@chanceaclark chanceaclark deleted the fix/inventory-handling branch November 22, 2024 20:30
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-crf6s5x87-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants