Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): provide a fallback locale for translations #1672

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

CI run for #1659

Testing

See CI

@chanceaclark chanceaclark requested a review from a team as a code owner November 21, 2024 17:36
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:38pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 21, 2024 5:38pm
catalyst-au ⬜️ Ignored (Inspect) Nov 21, 2024 5:38pm
catalyst-soul ⬜️ Ignored (Inspect) Nov 21, 2024 5:38pm
catalyst-uk ⬜️ Ignored (Inspect) Nov 21, 2024 5:38pm

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: f4a94b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chanceaclark chanceaclark added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit ffefc61 Nov 21, 2024
11 of 12 checks passed
@chanceaclark chanceaclark deleted the external-pr branch November 21, 2024 17:43
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-qm7tbm8jf-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants