fix(core): refresh the entire list of addresses after deleting an address #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 6d2feac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bc-yevhenii-buliuk
force-pushed
the
fix-address-list-pagination
branch
from
2057579 to
fb8f08e
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-address-list-pagination
branch
from
fb8f08e to
a76192d
Compare
bc-alexsaiannyi
approved these changes
Nov 19, 2024
|
just don't forget to fix lint errors |
bc-yevhenii-buliuk
force-pushed
the
fix-address-list-pagination
branch
from
a76192d to
04cdb1a
Compare
chanceaclark
force-pushed
the
fix-address-list-pagination
branch
from
04cdb1a to
51c1585
Compare
bc-yevhenii-buliuk
requested review from
a team
and removed request for
a team
chanceaclark
reviewed
Dec 3, 2024
core/app/[locale]/(default)/account/(tabs)/addresses/_actions/delete-address.ts
Outdated
Show resolved
Hide resolved
deini
approved these changes
Dec 4, 2024
bc-yevhenii-buliuk
force-pushed
the
fix-address-list-pagination
branch
from
f5577b1 to
ba71147
Compare
…ress and redirect to the first page
bc-yevhenii-buliuk
force-pushed
the
fix-address-list-pagination
branch
from
ba71147 to
6d2feac
Compare
chanceaclark
approved these changes
Dec 5, 2024
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-1x8ssjyf8-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
What/Why?
This PR fixes the display of the existing address list after removing all visible addresses on the page.
Also this PR updates the entire list of addresses after deleting an address.
Testing
locally
before:
addresses_pagination_before.mov
after:
addresses_pagination_after.mov