feat(core): add customer account orders functionality #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ec0e3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
bc-alexsaiannyi
changed the title
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
e709701 to
c61ffa8
Compare
|
@bc-alexsaiannyi I think we can squash this into one commit with a single changeset |
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
c61ffa8 to
f6f7da9
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
f6f7da9 to
d5221c4
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
d5221c4 to
0d4c801
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
0d4c801 to
60ec886
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
f953ffa to
31655a9
Compare
chanceaclark
approved these changes
Nov 15, 2024
jorgemoya
previously requested changes
Nov 15, 2024
There was a problem hiding this comment.
For order details, we should rely on slugs to fetch details. Lets create a page for /account/orders/[id] to display order content, instead of using search params to know what to render.
We also should rely more on Suspense boundaries and loading states to make sure this page is speedy.
core/app/[locale]/(default)/account/(tabs)/orders/_components/orders-content.tsx
Outdated
Show resolved
Hide resolved
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
31655a9 to
2410b6c
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
cb21e0f to
d813b53
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
d813b53 to
520cbd1
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
520cbd1 to
4987ef7
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
6aa9489 to
1ff4bd2
Compare
bc-alexsaiannyi
force-pushed
the
account-orders
branch
from
1ff4bd2 to
addf5ce
Compare
|
Hey @jorgemoya, I think that mentioned concerns have been addressed in separate PRs that are already merged in this branch. Can you please look at it once more if we're good to go🙏 |
feat(core): add order details components & update page data feat(core): add translations for order details page, small fixes for multi consignments order refactor(core): update header and account home page links after refactoring fix(core): simplify UI with respect to available data fix(core): move orders connection under customer in respect with api fix(core): update quantity of items in order truncated card refactor(core): update getTranslations for orders fix(core): separate promotions and coupons for order summary refactor(core): update OrderItemFragment according to API changes refactor(core): update in respect with storefront token changes feat(core): add images for order items refactor(core): Next15 upgrade asynchronous searchparams for orders page feat(core): add path to PDP for Orders fix(core): update styles for product snippet refactor(core): add filters to orders query refactor(core): update order page to use slug refactor(core): add suspense boundaries & skeleton for product snippet in orders test(core): add account orders test
chanceaclark
force-pushed
the
account-orders
branch
from
12b3723 to
2ec0e3e
Compare
chanceaclark
approved these changes
Dec 9, 2024
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-pn9rpraxb-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR combines and brings Order functionality to Customer's Account.
Testing
locally
Account_Orders.mov