Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): fetch locales at build time #1631

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat(core): fetch locales at build time #1631

merged 1 commit into from
Nov 12, 2024

Conversation

deini
Copy link
Member

@deini deini commented Nov 12, 2024

What/Why?

  • Adds build time config, which writes a .json file that can be read at runtime
  • Fetch available locales at build time and stores them in build config

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 2fb13ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 5:46pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 12, 2024 5:46pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 5:46pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 5:46pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 5:46pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 5:46pm

@deini deini added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 58d9e7c Nov 12, 2024
12 checks passed
@deini deini deleted the locale-build-config branch November 12, 2024 19:35
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-jjlyrg6wg-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 86
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants