Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update styles for reset password validation #1511

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

bc-alexsaiannyi
Copy link
Contributor

What/Why?

The PR improves styles for reset password page like:

  • fix invalid email validation
  • update colour & size for validation errors
  • fix ReCaptcha colour

Testing

locally

change_password_fix.mov
change_password_before change_password_after

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:29am
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:29am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 9:29am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 9:29am
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 9:29am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 9:29am
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 9:29am

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 947a46b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@bc-azvierieva bc-azvierieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bc-alexsaiannyi bc-alexsaiannyi added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 370d0b1 Oct 30, 2024
11 of 13 checks passed
@bc-alexsaiannyi bc-alexsaiannyi deleted the fix-reset-password-page branch October 30, 2024 12:23
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-7ni8px36y-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 82
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants