Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through BC channel ID as env var in basic workflow #1465

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

3rd Party Contributions, running CI on this code.

Testing

See CI.

@chanceaclark chanceaclark requested a review from a team as a code owner October 15, 2024 14:51
Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: ba7ca17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:53pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 15, 2024 2:53pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Oct 15, 2024 2:53pm
catalyst-au ⬜️ Ignored (Inspect) Oct 15, 2024 2:53pm
catalyst-test-store ⬜️ Ignored (Inspect) Oct 15, 2024 2:53pm
catalyst-uk ⬜️ Ignored (Inspect) Oct 15, 2024 2:53pm
catalyst-unstable ⬜️ Ignored (Inspect) Oct 15, 2024 2:53pm

@chanceaclark chanceaclark added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 952c325 Oct 15, 2024
14 checks passed
@chanceaclark chanceaclark deleted the contributions branch October 15, 2024 14:59
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-onxtw35te-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants