Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit cache policy on favicon fetch at build time #1451

Closed
wants to merge 1 commit into from

Conversation

bookernath
Copy link
Contributor

What/Why?

Explicitly no-store the favicon fetch at build time; ensures we get a fresh favicon every build.

Testing

N/A

@bookernath bookernath requested a review from a team as a code owner October 13, 2024 15:06
Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:18pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:18pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 6:18pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 6:18pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 6:18pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 6:18pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 6:18pm

Copy link

changeset-bot bot commented Oct 13, 2024

🦋 Changeset detected

Latest commit: 09d36d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide how you tested this? IIRC the cache should be fresh on each build 🤔

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-l69g3dfyq-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants