Add new env variable for Trusted Proxy #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f62efba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
bookernath
force-pushed
the
trusted-proxy
branch
2 times, most recently
from
7d2bddc to
773278e
Compare
bookernath
force-pushed
the
trusted-proxy
branch
from
773278e to
fc67e57
Compare
bookernath
force-pushed
the
trusted-proxy
branch
from
ce27291 to
c83e868
Compare
bookernath
force-pushed
the
trusted-proxy
branch
from
c83e868 to
eb3b5b3
Compare
bookernath
force-pushed
the
trusted-proxy
branch
from
eb3b5b3 to
bbf1648
Compare
Co-Authored-By: Chancellor Clark <[email protected]>
bookernath
force-pushed
the
trusted-proxy
branch
from
bbf1648 to
f62efba
Compare
chanceaclark
approved these changes
Oct 14, 2024
jorgemoya
approved these changes
Oct 14, 2024
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-c3r2p8nzo-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
If the store has Trusted Proxy enabled, the trusted proxy secret can be stored as an env variable in which case it will be sent as a header on all requests.
Testing
Verified via logs