Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): variant selection with pre-selected options #1446

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

deini
Copy link
Member

@deini deini commented Oct 11, 2024

What/Why?

When a product has pre-selected options, the state of the PDP was not selecting the correct variant.

Testing

BpWpc20W.mp4

@deini deini requested a review from a team as a code owner October 11, 2024 17:40
Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 1728cc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 5:40pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Oct 11, 2024 5:40pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Oct 11, 2024 5:40pm
catalyst-au ⬜️ Ignored (Inspect) Oct 11, 2024 5:40pm
catalyst-test-store ⬜️ Ignored (Inspect) Oct 11, 2024 5:40pm
catalyst-uk ⬜️ Ignored (Inspect) Oct 11, 2024 5:40pm
catalyst-unstable ⬜️ Ignored (Inspect) Oct 11, 2024 5:40pm

@deini deini added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit ba4820b Oct 11, 2024
14 checks passed
@deini deini deleted the fix/default-selection branch October 11, 2024 17:58
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-2278s93aq-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 81
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants