feat(CORE): block notification displaying #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r block the notifications, so none are displayed to the user
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It basically adds an API for the plugin to decide whether to display the notification (As a default, it will follow the meeting's configuration of course, which is mostly to display notifications, so in this case, the plugin can turn it off, and when it fits the needs, turn it on)
How to test
One can use the SampleActionButtonDropdown to test, just like the demo video.
More
See demo video ahead:
sendDisplayNotificationDemo.mp4
Closely related to the CORE's PR: bigbluebutton/bigbluebutton#21846