Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It does 2 things in general:
The second point is there just so I can properly validate if the file size of the presentation that the person is sending is not bigger than expected.
Motivation
This will allow us to send PDFs into BBB via plugin so that new ways of uploading an h5p file can exist - this is for the h5p-plugin.
How to test
Just use the
sample-action-button-dropdown-plugin
in the plugin-sdk repository. It will upload automatically a sample presentation.To test the expected error, one can decrease the number in
manifest.assetPersistence.maxFileSize
to say 100, which means it allows a file with a maximum of 100 Bytes (pretty much any file you send is greater than that).More
See demo:
plugin-upload-presentation-demo.mp4
Closely related to CORE PR: bigbluebutton/bigbluebutton#21777
There is only one feature left to implement here
That is, the maximum file-size that a user can upload via the plugin, so that if we have 100MB for this config, the user can send 10 files of 10MB, for instance, or 20 files of 5MB, and so on.
This will be implemented once the issue bigbluebutton/bigbluebutton#21776 is fixed, because this will introduce a new type of expected error in the presentation.