Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): asset persistence #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GuiLeme
Copy link
Collaborator

@GuiLeme GuiLeme commented Nov 28, 2024

What does this PR do?

It does 2 things in general:

  • Creates a new feature for the plugins to use: the asset-persistence;
  • Fix the MaxFileSize error that was not happening;

The second point is there just so I can properly validate if the file size of the presentation that the person is sending is not bigger than expected.

Motivation

This will allow us to send PDFs into BBB via plugin so that new ways of uploading an h5p file can exist - this is for the h5p-plugin.

How to test

Just use the sample-action-button-dropdown-plugin in the plugin-sdk repository. It will upload automatically a sample presentation.

To test the expected error, one can decrease the number in manifest.assetPersistence.maxFileSize to say 100, which means it allows a file with a maximum of 100 Bytes (pretty much any file you send is greater than that).

More

See demo:

plugin-upload-presentation-demo.mp4

Closely related to CORE PR: bigbluebutton/bigbluebutton#21777

There is only one feature left to implement here

  • validate maxUploadSizePerUser;

That is, the maximum file-size that a user can upload via the plugin, so that if we have 100MB for this config, the user can send 10 files of 10MB, for instance, or 20 files of 5MB, and so on.

This will be implemented once the issue bigbluebutton/bigbluebutton#21776 is fixed, because this will introduce a new type of expected error in the presentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant