ref(samples): Refactor structure of plugins to match the new manifest.json file #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up to date, audited 793 packages in 1s 148 packages are looking for funding run `npm fund` for details found 0 vulnerabilities problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR basically updates the structure of plugins according to the new
manifest.jsonstructure. With the updates, there comes also the new documentation and fixes to whatever eslint or typescript errors/warnings that could appear as well as thenpm iproblems that kept happening.More
Just a comment to the reviewer: There seems to be a lot of change in this PR, but that's really not the case, it's mostly
package.jsonandpackage-lock.json, moreover, other file changes are mostly the same for every sample (just making necessary changes accordingly, e.g.: name of plugin, URL of plugin, etc.).One other important detail: there are still some other things to do after the merge of this PR, that being:
That's basically it. Should you have any other important change to add to this list, please, comment down below.