fix(extensible-areas): change return type of contentFunction
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is necessary because the components provided by plugins, when rendered in the core, were left in the DOM Tree. This occurs because the plugins and the core are two separate ReactJS applications, each using its own ReactDOM instance. The `contentFunction` must now return the root element created by the plugin's ReactDOM instance to allow the core to properly unmount it.
- Updates samples using `contentFunction` to return the created root element. - Adds missing `open` parameter in SampleGenericContentSidekickPlugin.
|
Published in SDK version v0.0.60 |
|
I have just updated the related BBB-core PR to point to the right SDK's version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the return type of
contentFunctionin FloatingWindow and GenericContent extensible areas.This change is necessary because the components provided by plugins, when rendered in the core, were left in the DOM Tree. This occurs because the plugins and the core are two separate ReactJS applications, each using its own ReactDOM instance. The
contentFunctionmust now return the root element created by the plugin's ReactDOM instance to allow the core to properly unmount it.Closes Issue(s)
Closes #112
More
Relate Core's PR: