!fix: track DOM elements in useChatMessagesDomElements with pagination
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the state for clarity, as it stores an array of DOM elements.
Set the initial value of the state `domElements` to an empty array for consistency with its declared type. This ensures the hook returns a more appropriate value(an empty array) when no message IDs are passed.
The `useChatMessagesDomElements` hook was expecting all DOM elements from the rendered chat messages to be sent in a single event. However, due to the pagination mechanism in the bbb-core, only messages from the same page are sent together, which caused DOM elements from the last rendered page to overwrite those from previous pages. This commit adds support for pagination when storing DOM elements, ensuring that elements from different pages do not overwrite each other. It also includes a cleanup mechanism to remove stored DOM elements when a page is unmounted (due to pagination rolling or chat toggling). This ensures that only valid elements are stored and prevents the list from growing indefinitely. Additionally, the hook's internal state management has been updated and the filtering for the requested message IDs has been moved to the render function to ensure that the returned DOM elements are correctly updated when message IDs passed via props change.
Removes the `messageIdsState` as the hook already reacts to the message IDs passed via props, making the internal state redundant.
Checks whether the page is valid before updating state. Also, fixes a state update that was not using the proper set state function.
TiagoJacobs
requested changes
Oct 3, 2024
|
Actually, the PR does not break the examples using the |
|
published in [email protected] ! |
Arthurk12
added a commit
to Arthurk12/bigbluebutton
that referenced
this pull request
Oct 7, 2024
Updates the plugins SDK to version 0.0.64 based on the discussion in pull request bigbluebutton#113: bigbluebutton/bigbluebutton-html-plugin-sdk#113 (comment)
Arthurk12
added a commit
to Arthurk12/bigbluebutton
that referenced
this pull request
Oct 7, 2024
Updates the plugins SDK to version 0.0.64 based on the discussion in pull request: bigbluebutton/bigbluebutton-html-plugin-sdk#113 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
useChatMessagesDomElementshook was designed to expect all DOM elements from the rendered chat messages to be sent in a single event. However, due to the pagination mechanism in the bbb-core, only messages from the same page are sent together, which caused DOM elements from the last rendered page to overwrite those from previous pages.This PR introduces support for pagination when storing DOM elements, ensuring that elements from different pages do not overwrite each other. It also includes a cleanup mechanism to remove stored DOM elements when a page is unmounted (due to pagination rolling or chat toggling). This ensures that only valid elements are stored and prevents the list from growing indefinitely.
Additionally, the hook's internal state management has been updated and the filtering for the requested message IDs has been moved to the render function to ensure that the returned DOM elements are correctly updated when message IDs passed via props change.
Breaking change: Modified the structure of data exchanged in window events
UpdatedEventDetailsForChatMessageDomElements.Closes Issue(s)
Closes #111
Note for reviewer
useLoadedChatMessageshook, which is not returning all loaded message IDs in such cases and should be addressed in a separate issue/PR.useLoadedChatMessagesand then requests some of those IDs touseChatMessagesDomElements.useLoadedChatMessagesis returning all IDs correctly.More
Relate bbb core PR: bigbluebutton/bigbluebutton#21176