Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS refactoring. #168

Merged
merged 47 commits into from
Jul 16, 2024
Merged

OLS refactoring. #168

merged 47 commits into from
Jul 16, 2024

Conversation

ypriverol
Copy link
Member

@ypriverol ypriverol commented Jul 13, 2024

OLS is mainly used to validate the terms for each column of the SDRF. However, OLS could be unstable failing the entire validation.

The following PR does:

  • Check if the OLS is running.
  • Check if the given ontology, for example PSI-MS, is available.
  • All tests related with the OLSClient are updated.
  • Conda build tested.

Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .
    Once you push these changes the test should pass, and you can hide this comment 👍
    We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!
    Thanks again for your contribution!

@ypriverol ypriverol merged commit 633da2c into main Jul 16, 2024
10 checks passed
@ypriverol ypriverol deleted the ypriverol-patch-1 branch July 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants