Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Setting the diann_speclib to an empty string breaks the pipeline #372

Closed
jspaezp opened this issue May 10, 2024 · 3 comments · Fixed by #373
Closed

[BUG] Setting the diann_speclib to an empty string breaks the pipeline #372

jspaezp opened this issue May 10, 2024 · 3 comments · Fixed by #373
Labels
bug Something isn't working

Comments

@jspaezp
Copy link

jspaezp commented May 10, 2024

Description of the bug

Hey there!

Setting the diann_speclib to an empty string breaks the pipeline with

[main] DEBUG nextflow.Session - Session aborted -- Cause: Missing `fromPath` parameter

if (params.diann_speclib != null) {

A while ago I had it as if (...) (https://github.com/bigbio/quantms/blame/e3c95f038192db53b41bd9b072687b549dfff5db/workflows/dia.nf#L59) and later it was changed to if (... == Null), which makes it such that having an empty string WAS but IS NO LONGER equivalent to not setting the parameter.

I think both should be supported but its not critical (TBH i think its more of a nextflow issue ... where the error is very bad at fromPath).

LMK if you think we should invest some time supporting both the empty and the null as options to generate a new library.

TLDR:
-> Situation: When the parameter diann_speclib is set to ""
-> Outcome: the pipeline fails with a cryptic error message.
-> Expected outcome: A new library is generated as if diann_speclib was not set at all.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@jspaezp jspaezp added the bug Something isn't working label May 10, 2024
@ypriverol
Copy link
Member

@jspaezp Do you think you can tackle the issue? I guess is to validate the path variable for null and empty?

@jspaezp
Copy link
Author

jspaezp commented May 10, 2024

It is IN THEORY an easy fix. I dont think I will have time to tackle it in the next week or so. I can do it after that though! I just wanted to make sure I left the report once I figured out the error.

@daichengxin daichengxin linked a pull request May 11, 2024 that will close this issue
11 tasks
@jspaezp
Copy link
Author

jspaezp commented May 13, 2024

Thanks for squeezing the fix in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants