Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MBR in DIA-NN step #238

Open
daichengxin opened this issue Nov 1, 2022 · 4 comments
Open

Enable MBR in DIA-NN step #238

daichengxin opened this issue Nov 1, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@daichengxin
Copy link
Collaborator

Description of feature

Now, due to make things as parallelisable as possible, Thus, step 2 consists of analysing each run separately with the in silico library generated in step 1. so we should think about adding MBR in one big node . See details: #164

@daichengxin daichengxin added the enhancement New feature or request label Nov 1, 2022
@calizilla
Copy link

Hi, this is marked as completed, but I don't see the --reanalyse parameter anywhere in the code. What was the strategy to implement MBR for parallelised DiaNN?

@ypriverol
Copy link
Member

@Calliza you are right. Let me re-open the issue.

@ypriverol ypriverol reopened this Jul 28, 2023
@michaelsteidel86
Copy link

Is this still considered as an open issue? To my understanding the re-analysis step based on the empirical library actually is an MBR -analysis. Please correct me if I am wrong. So --re-analysis is only required if full analysis (1st and 2nd pass) are being in one step (non-parallelized)

@calizilla
Copy link

Is this still considered as an open issue? To my understanding the re-analysis step based on the empirical library actually is an MBR -analysis. Please correct me if I am wrong. So --re-analysis is only required if full analysis (1st and 2nd pass) are being in one step (non-parallelized)

Yes I think you are correct, apologies for causing a re-open, I was new to DIA-NN at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants