Make loop variables local

bhavanki · Jun 23, 2022 · 06b8aff · 06b8aff
1 parent a6f0aa5
commit 06b8aff
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/abom_components.bash b/abom_components.bash
@@ -374,6 +374,7 @@ abom_render_progress() {
   local pct=$(struct_get "$el" pct)
 
   local bar_len=$(( pct * len / 100 ))
+  local i
   for (( i = 0; i < len; i++ )); do
     if (( i < bar_len )); then
       printf '█'

diff --git a/abom_lib.bash b/abom_lib.bash
@@ -150,6 +150,7 @@ abom_init() {
   hide_cursor
 
   TUI_LINES=$lines
+  local i
   for (( i = 0; i < TUI_LINES; i++ )); do
     echo
   done
@@ -165,6 +166,7 @@ abom_clear() {
     return
   fi
 
+  local i
   for (( i = 0; i < TUI_LINES; i++ )); do
     delete_to_eol
     next_line_start
@@ -192,6 +194,7 @@ abom_render() {
   curr_pos=$(get_cursor_pos)
   local diff_lines
   diff_lines=$(( $(get_line_from_pos "${curr_pos}") - root_line ))
+  local i
   for (( i = 0; i < TUI_LINES - diff_lines; i++ )); do
     delete_to_eol
     next_line_start

diff --git a/abom_struct.bash b/abom_struct.bash
@@ -13,6 +13,7 @@
 make_struct() {
   local s=""
   local argct=$#
+  local i
   for (( i = 0; i < argct; i += 2 )); do
     local key=$1
     local value=$2