fix(agent-auth): claim before-hook by token typ, not JWT shape#31
Open
dbworku wants to merge 1 commit into
Open
fix(agent-auth): claim before-hook by token typ, not JWT shape#31dbworku wants to merge 1 commit into
dbworku wants to merge 1 commit into
Conversation
The agent-auth `before` hook matched any request carrying a 3-segment Bearer JWT and then hard-rejected it with INVALID_JWT when the token's protected-header `typ` was not "host+jwt" or "agent+jwt". On a betterAuth() instance composed with another plugin that issues its own JWTs (e.g. @better-auth/infra's dash() plugin), this intercepted and 401'd requests the other plugin owned, before its routes could validate them. Claim requests by token ownership instead: decode the protected header in the matcher and only handle tokens whose `typ` is "host+jwt"/"agent+jwt". Foreign Bearer JWTs now pass through untouched to the plugin that owns them. Fixes better-auth/better-auth#9885
|
@dbworku is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent-auth
beforehook matched any request carrying a 3-segment Bearer JWT and then hard-rejected it with INVALID_JWT when the token's protected-headertypwas not "host+jwt" or "agent+jwt". On a betterAuth() instance composed with another plugin that issues its own JWTs (e.g. @better-auth/infra's dash() plugin), this intercepted and 401'd requests the other plugin owned, before its routes could validate them.Claim requests by token ownership instead: decode the protected header in the matcher and only handle tokens whose
typis "host+jwt"/"agent+jwt". Foreign Bearer JWTs now pass through untouched to the plugin that owns them.Fixes better-auth/better-auth#9885