refactor(API): Imports: nouvelle class CSVImportApiView générique (qui check le format, la taille max, et si déjà uploadé) #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
commented
Jan 17, 2025
| f"Ce fichier est au format {self.file.content_type}, merci d'exporter votre fichier au format CSV et réessayer." | ||
| ) | ||
|
|
||
| def _get_file_digest(self): |
There was a problem hiding this comment.
je l'ai mis ici car j'aimerais à terme rajouter la logique "fichier identique ?" pour les imports cantines/diagnostics. enfin je ne suis pas 100% certain de sa faisabilité, en tout cas on ne stock pas le md5 actuellement pour ces imports, mais ca serait utile pour tous les futurs !
raphodn
changed the title
This was referenced Jan 23, 2025
raphodn
commented
Jan 24, 2025
| from simple_history.utils import update_change_reason | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class CSVImportApiView(APIView): |
There was a problem hiding this comment.
pour info, dans ce commentaire - #4896 (comment) - je me pose la question si c'est une classe DRF qu'on doit utiliser, ou plutôt un simple fichier utils python avec les différentes méthodes
There was a problem hiding this comment.
parce que ces appels "super()", et l'utilisation un peu magique de "self.", ce n'est pas très très joli je trouve ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi
Suite de #4934
Baby step pour commencer à factoriser les premières étapes de traitement d'un fichier CSV :
Du coup dans
PurchaseImportle check pour savoir si le fichier a déjà été importé se fait en amont maintenant :