Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update canteen.py > class Ministries > Labels Open data #4812

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

Update canteen.py > class Ministries > Labels Open data #4812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions data/models/canteen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,29 +123,29 @@ class Actions(models.TextChoices):

class Ministries(models.TextChoices):
AFFAIRES_ETRANGERES = "affaires_etrangeres", "Affaires étrangères"
AGRICULTURE = "agriculture", "Agriculture, Alimentation et Forêts"
ARMEE = "armee", "Armées"
TERRITOIRES = "territoires", "Cohésion des territoires - Relations avec les collectivités territoriales"
AGRICULTURE = "agriculture_alimentation", "Agriculture, Alimentation et Forêts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

là ca ne change pas les labels, mais les clés, celles utilisées/stockées dans la base de données
du coup ca va demander quelques changements supplémentaires

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est-ce que c'est amené à changer souvent ?
est-ce que ca concerne seulement l'open data ?

une option est de laisser tel quel (sans changement à la BDD), mais venir modifier/remplacer les les valeurs au moment des exports.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mais ca ne me semble pas judicieux de faire ces changements au moment de l'export, car je préférerais que des données exportées puissent être réimportées sans modification. donc à moins de changer aussi l'import...

ARMEE = "armees", "Armées"
TERRITOIRES = "territoires_relations", "Cohésion des territoires - Relations avec les collectivités territoriales"
CULTURE = "culture", "Culture"
ECONOMIE = "economie", "Économie et finances"
JEUNESSE = "jeunesse", "Éducation et Jeunesse"
ENSEIGNEMENT_SUPERIEUR = "enseignement_superieur", "Enseignement supérieur et Recherche"
ECOLOGIE = "ecologie", "Environnement"
TRANSFORMATION = "transformation", "Fonction Publiques"
ECONOMIE = "economie_finances", "Économie et finances"
JEUNESSE = "education_jeunesse", "Éducation et Jeunesse"
ENSEIGNEMENT_SUPERIEUR = "superieur_recherche", "Enseignement supérieur et Recherche"
ECOLOGIE = "environnement", "Environnement"
TRANSFORMATION = "fonction_publique", "Fonction Publiques"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TRANSFORMATION = "fonction_publique", "Fonction Publiques"
TRANSFORMATION = "fonction_publiques", "Fonction Publiques"

INTERIEUR = "interieur", "Intérieur et Outre-mer"
JUSTICE = "justice", "Justice"
MER = "mer", "Mer"
ADMINISTRATION_TERRITORIALE = (
"administration_territoriale",
"prefecture_ATE",
"Préfecture - Administration Territoriale de l'État (ATE)",
)
AUTORITES_INDEPENDANTES = (
"autorites_independantes",
"presidence_autre",
"Présidence de la république - Autorités indépendantes (AAI, API)",
)
PREMIER_MINISTRE = "premier_ministre", "Services du Premier Ministre"
SANTE = "sante", "Santé et Solidarités"
SPORT = "sport", "Sport"
SANTE = "sante_solidarites", "Santé et Solidarités"
SPORT = "sports", "Sports"
TRAVAIL = "travail", "Travail"
OUTRE_MER = "outre_mer", "Ministère des Outre-mer"
AUTRE = "autre", "Autre"
Expand Down
Loading