Migration vers ProConnect (MAJ variables d'env necessaire) #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b00dd44.
This reverts commit 3c3871e. With conflict resolution, this isn't a perfect revert
Update pre-commit flake8 config to fix bug https://stackoverflow.com/questions/75591296/entrypoints-object-has-no-attribute-get-during-running-pre-commit
This reverts commit 002941c.
…f ProConnect tokens
hfroot
commented
Nov 26, 2024
hfroot
commented
Nov 26, 2024
hfroot
commented
Nov 26, 2024
| "fields": ( | ||
| "created_with_proconnect", | ||
| "proconnect_id", | ||
| "proconnect_organizations", |
There was a problem hiding this comment.
j'ai rajouté ces données pour qu'on puisse s'assurer que la migration des comptes créés avec MonComptePro a bien reussi
hfroot
commented
Nov 26, 2024
hfroot
commented
Nov 26, 2024
hfroot
changed the title
hfroot
commented
Nov 26, 2024
| client_kwargs={"scope": "openid email profile organizations"}, | ||
| name="proconnect", | ||
| server_metadata_url=settings.PROCONNECT_CONFIG, | ||
| client_kwargs={"scope": "openid email given_name usual_name siret", "leeway": 30}, |
There was a problem hiding this comment.
Issu ouvert côté Authlib pour améliorer le docs pour leeway et autres config lepture/authlib#687
This reverts commit dc0e510.
|
idées :
ce qu'il reste à faire :
à vérifier :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
à faire avant merger: plan pour la MEP
https://github.com/numerique-gouv/proconnect-documentation/blob/main/doc_fs/datapass-fs.md
Differences MCP et ProConnect
ProConnect n'envoie pas le numero telephone
ProConnect envoie que un établissement (MCP avait plusieurs) alors j'ai recréé la liste
ProConnect a que le SIRET de l'étab et non pas le nom aussi
ProConnect envoie un format de token qui est inconnu par Authlib alors j'ai du reprendre un hack utilisé par une autre équipe pour lire les tokens
Les tokens de ProConnect ont un temps d'expiration de 60s, MCP de 3600s. Alors j'ai du configurer le
leewayde notre client pour être moins de 60s.Flow utilisateur
Pour les nouveaux utilisateurs (alors celleux qui sont rattachés à un établissement côté ProConnect mais qui n'ont pas une cantine chez nous), on propose le shortcut de créer leur cantine à partir du siret envoyé par ProConnect (mais le siret du compte de test ne passe pas le test de Luhn)