Permettre le remplacement d'une demande avec un autre type d'ingrédient #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge resolving conflicts and fixing a bug with synonym parsing
4 tasks
Pass replacement element in element key, put other info about the existing request in the first level, to ensure we are copying across info as well as saving the new info for the new type.
Previously needed to explicitly ignore it in code
hfroot
added a commit
that referenced
this pull request
Jan 21, 2025
hfroot
added a commit
that referenced
this pull request
Jan 21, 2025
hfroot
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vu qu'il y a des champs supplementaires demandés qui change par type d'ingrédient, j'ai refactorisé le code pour créer un composant réutilisé entre l'onglet composition quand on crée une déclaration, et par le modal pour le remplacement.
remaining todo