fix(api): handle undefined exercise 🙄

betagouv · Nov 7, 2024 · 03e37fb · 03e37fb
1 parent 3e338b1
commit 03e37fb
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 5 deletions.
diff --git a/packages/api/src/modules/grant/grant.adapter.ts b/packages/api/src/modules/grant/grant.adapter.ts
@@ -67,7 +67,8 @@ export default class GrantAdapter {
             // application part
             exercice:
                 grant?.application?.annee_demande?.value ??
-                paymentService.getPaymentExercise((grant?.payments as Payment[])[0]),
+                paymentService.getPaymentExercise((grant?.payments as Payment[])?.[0]) ??
+                0,
             action: getValue(grant?.application?.actions_proposee?.[0]?.intitule),
             askedAmount: getValue(grant?.application?.montants?.demande),
             grantedAmount: getValue(grant?.application?.montants?.accorde),

diff --git a/packages/api/src/modules/grant/grant.service.ts b/packages/api/src/modules/grant/grant.service.ts
@@ -267,9 +267,10 @@ export class GrantService {
     splitGrantByExercise(grant: Grant): Grant[] {
         const { application, payments } = grant;
         const byYear: Record<number, Grant> = {};
-        const NO_YEAR = "unknown";
+        const NO_YEAR = 0;
 
-        if (application) byYear[subventionsService.getSubventionExercise(application) ?? NO_YEAR] = { application };
+        if (application)
+            byYear[subventionsService.getSubventionExercise(application) ?? NO_YEAR] = { application, payments: null };
 
         let year: number;
         for (const payment of payments ?? []) {

diff --git a/packages/api/src/modules/payments/payments.service.test.ts b/packages/api/src/modules/payments/payments.service.test.ts
@@ -54,5 +54,11 @@ describe("PaymentsService", () => {
             const actual = paymentsService.getPaymentExercise(PAYMENT);
             expect(actual).toBe(expected);
         });
+
+        it("returns undefined if payment is undefined", () => {
+            const expected = undefined;
+            const actual = paymentsService.getPaymentExercise(undefined);
+            expect(actual).toBe(expected);
+        });
     });
 });
diff --git a/packages/api/src/modules/payments/payments.service.ts b/packages/api/src/modules/payments/payments.service.ts
@@ -26,8 +26,9 @@ export class PaymentsService {
         });
     }
 
-    getPaymentExercise(payment: Payment) {
-        return payment.dateOperation.value.getFullYear();
+    getPaymentExercise(payment: Payment | undefined) {
+        if (!payment) return undefined;
+        return payment?.dateOperation?.value?.getFullYear();
     }
 }
 

diff --git a/packages/api/tests/interfaces/http/__snapshots__/associations.spec.ts.snap b/packages/api/tests/interfaces/http/__snapshots__/associations.spec.ts.snap
@@ -78,6 +78,7 @@ Object {
           "value": "f84f45a69fca47a7f8a36665b94db7719208abdf",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -148,6 +149,7 @@ Object {
           "value": "Accordé",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -224,6 +226,7 @@ Object {
           "value": "74959357aff2a17c3a876310f5d90bb037a80427",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -448,6 +451,7 @@ Object {
           "value": "2103814945",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -573,6 +577,7 @@ Object {
           "value": "EJ00001",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -942,6 +947,7 @@ Object {
           "value": "f84f45a69fca47a7f8a36665b94db7719208abdf",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -1012,6 +1018,7 @@ Object {
           "value": "Accordé",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -1088,6 +1095,7 @@ Object {
           "value": "74959357aff2a17c3a876310f5d90bb037a80427",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -1312,6 +1320,7 @@ Object {
           "value": "2103814945",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {
@@ -1437,6 +1446,7 @@ Object {
           "value": "EJ00001",
         },
       },
+      "payments": null,
     },
     Object {
       "application": Object {