Fix autoconnect for plugins

[haslinghuis]

Summary by CodeRabbit

• Bug Fixes
  • Initialized connection state to avoid undefined behavior during serial device handling.
  • Tightened auto-selection validation so device detection is more reliable, reducing false or incorrect automatic connections and improving overall connection stability.

[coderabbitai]

Walkthrough

Modified serial device auto-selection logic in src/js/serial_backend.js by explicitly initializing connectionTimestamp to null and extending the auto-select-serial-device condition to require connectionTimestamp is null or > 0.

Changes

Cohort / File(s)	Summary
Serial backend auto-select enhancement src/js/serial_backend.js	Initialize connectionTimestamp to null; extend auto-select-serial-device condition to require connectionTimestamp is null or > 0.

Sequence Diagram(s)

sequenceDiagram
    participant UI as UI
    participant SB as SerialBackend
    participant Device as SerialDevice

    rect #f8f9fa
      note right of SB: connectionTimestamp initialized to null
    end

    UI->>SB: emit auto-select-serial-device
    alt device already selected
        SB->>UI: ignore (deviceSelected == true)
    else device not selected
        SB->>SB: evaluate autoSelect && (connectionTimestamp == null || connectionTimestamp > 0)
        alt condition true
            SB->>Device: attempt connect
            Device-->>SB: connected / error
            SB->>UI: notify result
        else condition false
            SB->>UI: skip auto-select
        end
    end

Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Fix auto-connect #4523: Modifies auto-connect logic in src/js/serial_backend.js, touching related auto-selection conditions.

Suggested reviewers

• nerdCopter
• VitroidFPV

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is entirely missing. The repository's description template provides comprehensive guidelines and requires authors to either follow the template structure or provide meaningful context about their changes, but the author has not provided any description content. This represents a largely incomplete submission that fails to communicate the purpose, impact, or rationale for the changes beyond what the title conveys.	Please add a pull request description that explains the bug being fixed, how the changes address it, and any relevant context. At minimum, clarify the issue with autoconnect for plugins and explain how initializing connectionTimestamp and extending the auto-select-serial-device condition resolves it. If this pull request fixes an existing GitHub issue, reference it using the format "Fixes #" as specified in the repository guidelines.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Fix autoconnect for plugins" is concise and directly related to the changes made in the changeset. The modifications to serial_backend.js specifically address the auto-select-serial-device condition by initializing connectionTimestamp and adding additional checks, which aligns with fixing autoconnect functionality. The title is clear and specific enough for a teammate scanning the history to understand the primary purpose of the change.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcb0bb4 and df852f8.

📒 Files selected for processing (1)

• src/js/serial_backend.js (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/js/serial_backend.js

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://pr4674.betaflight-app-preview.pages.dev

[YarosMallorca]

Tested, works as intended auto-connecting from welcome screen and after saving from CLI

[Pancronos]

Tested to work fine, even with auto reconnect between CLI > any tab