Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0/cleanup lifecycles #386

Merged
merged 11 commits into from
Mar 27, 2024
Merged

5.0/cleanup lifecycles #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b4531d6
Fix typo of "nonexistent"
sunnavy Jul 21, 2021
9cdf371
Clean up lifecycles on save when possible
sunnavy Jul 21, 2021
4f0700d
Trim any leading and trailing spaces from name on lifecycle create
sunnavy Jan 31, 2024
ce3adb0
Do not merge old values for hash configs in database
sunnavy Feb 1, 2024
e19e055
Support to delete lifecycles
sunnavy Feb 1, 2024
ae7daec
Test lifecycle deletions
sunnavy Feb 5, 2024
302af2a
Show lifecycle warnings to admins who are accessing lifecycle pages
sunnavy Feb 2, 2024
24342d3
Add protective code in case of invalid lifecycles
sunnavy Feb 5, 2024
1753c63
Test lifecycle warnings on admin web UI
sunnavy Feb 5, 2024
3e9651f
Support to update maps of a lifecycle via JSON on Advanced page
sunnavy Feb 2, 2024
169ea4a
Add links to help map statuses that have the same name
sunnavy Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/cpanfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ requires 'HTTP::Message', '>= 6.07';
requires 'IPC::Run3';
requires 'JavaScript::Minifier::XS';
requires 'JSON';
requires 'List::MoreUtils';
requires 'List::MoreUtils', '>= 0.420';
requires 'Locale::Maketext', '>= 1.06';
requires 'Locale::Maketext::Fuzzy', '>= 0.11';
requires 'Locale::Maketext::Lexicon', '>= 0.32';
Expand Down
5 changes: 2 additions & 3 deletions lib/RT/Config.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3077,10 +3077,9 @@ sub LoadConfigFromDatabase {
: $type eq 'HASH' ? [ %$value ]
: [ $value ];

# hashes combine, but by default previous config settings shadow
# later changes, here we want database configs to shadow file ones.
# Unlike hashes in files that merge together, database configs are supposed to contain all the data, so no need
# to merge file configs. With it, admins are able to delete keys.
if ($type eq 'HASH') {
$val = [ $self->Get($name), @$val ];
$self->Set($name, ());
}

Expand Down
Loading
Loading