5.0/create chart images for dashboard emails 2 #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the dashboard emails to contain image versions of JSChart graphs obtained using WWW::Mechanize::Chrome. Previously it was only possible to generate graph images for emails using the GD module. This Feature has been tested with Chrome, Chromium, Microsoft Edge, and Opera.
The issue was initially noticed from dashboard jschart tests: tests could pass with devel mode on but not without it. Turned out that ckeditor.min.js has UTF-8 BOM and encoding the BOM twice broke js syntax. Unlike devel mode where js files are wrapped into independent "script" tags, squished js is wrapped into a single tag, thus JSChart related code couldn't run because of earlier syntax error. This commit makes sure that all text contents are decoded consistently. Note that unlike css that $res->decoded_content automatically decodes since its content type starts with "text/", js is not automatically decoded by $res->decoded_content as its content type starts with "application/".
The easiest approach is to convert these files using dos2unix.
bestpractical-mirror
deleted the
5.0/create-chart-images-for-dashboard-emails-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.