5.0/asset inline edit #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t yet Custom role groups could be absent if the corresponding custom roles were created/applied after some assets or the lazy option is enabled.
Inline edit doesn't actually work for them anyway, because of the absent helper component. Previously we disabled it in /SelfService/Elements/MyRequests, which is not enough any more as now we support various components for SelfService especially via dashboards.
cbrandtbuffalo
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Some questions on a few portlets:
- Links gets squashed in the 3-column view, making the labels wrap poorly. We should make it single column with existing values on top and edit on the bottom like tickets.
- I'm seeing a pencil for dates, but when I click there's nothing to edit because the core dates for assets (Created and LastUpdated) can't be edited. Maybe we should only show the pencil if there are CFs that can be edited? Otherwise it's confusing to be able to click the pencil but not be able to edit anything.
- I'm not seeing a pencil for custom fields. Something in my config?
Good catches, both are fixed.
There is a callback in "/Asset/Elements/EditDates" where users can do anything, so checking cfs might not be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.