Skip to content

Commit

Permalink
Make sure inline edit is disabled for unprivileged users
Browse files Browse the repository at this point in the history
Inline edit doesn't actually work for them anyway, because of the absent
helper component.

Previously we disabled it in /SelfService/Elements/MyRequests, which is
not enough any more as now we support various components for SelfService
especially via dashboards.
  • Loading branch information
sunnavy committed Dec 11, 2023
1 parent b9145e7 commit 4bd57e4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion share/html/Elements/CollectionList
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ foreach my $col (@Format) {

$Class ||= $Collection->ColumnMapClassName;

$InlineEdit = 0 unless $Collection->isa('RT::Tickets') || $Collection->isa('RT::Assets');
$InlineEdit = 0
unless $session{CurrentUser}->Privileged && ( $Collection->isa('RT::Tickets') || $Collection->isa('RT::Assets') );

$m->out('<div class="table-responsive">');
$m->out('<table cellspacing="0"');
Expand Down

0 comments on commit 4bd57e4

Please sign in to comment.