-
Notifications
You must be signed in to change notification settings - Fork 260
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In tests, call PostLoadCheck to enable Externalauth
02b0659 made the ExternalAuth meta-setting automatically enabled via PostLoadCheck, and 8946b1b removed the code in tests that set it. Because of the bug fixed in 43c1318, however, the ExternalAuth flag was always enabled, making tests pass. Post-43c13180, the PostLoadCheck is never called after the ->Set calls inside a testfile. As such, the ExternalAuth meta-setting is never enabled, and all external auth tests fail. Explicitly call ->PostLoadCheck after each block of ExternalAuth-related ->Set calls, to trigger the activation of the ExternalAuth meta-setting. Calling each configuration's PostLoadCheck hook automatically after each ->Set would require careful adjustment of the order of ->Set calls, which might be surprising behavior, as ordering is not important in `RT_SiteConfig.pm`.
- Loading branch information
Showing
6 changed files
with
6 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,7 @@ RT->Config->Set( | |
}, | ||
} | ||
); | ||
RT->Config->PostLoadCheck; | ||
|
||
my ( $baseurl, $m ) = RT::Test->started_ok(); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ RT->Config->Set( | |
}, | ||
} | ||
); | ||
RT->Config->PostLoadCheck; | ||
|
||
my ( $baseurl, $m ) = RT::Test->started_ok(); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,5 +117,6 @@ sub setup_auth_source { | |
}, | ||
} | ||
); | ||
RT->Config->PostLoadCheck; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,7 @@ RT->Config->Set( | |
}, | ||
} | ||
); | ||
RT->Config->PostLoadCheck; | ||
|
||
my ( $baseurl, $m ) = RT::Test->started_ok(); | ||
|
||
|