This repository has been archived by the owner on May 28, 2019. It is now read-only.
Modified for loops so there are no Closure Compiler warnings #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Travis CI tests for IoJS so that the out of date certificate store used by wget is no longer an issue (it uses cURL now).
|
Please could this pull request be reviewed? |
|
Any update on this please? |
ghost
mentioned this pull request
|
I'm so sorry this sat open for a year. I changed the loops to be less clever, so Closure Compiler shouldn't warn, and filed #91 for fixing the tests. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the Travis CI tests for IoJS so that the out of date certificate store used by wget is no longer an issue (it uses cURL now).
Sauce Labs CI tests on Travis are failing because it appears you now need a username and access key. Please see https://docs.travis-ci.com/user/sauce-connect/.