[curator-viewer] enabled toast instead of alert for copy paste, and fixed streaming toast #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieJCJ
changed the title
CharlieJCJ
changed the title
|
Need additional testing on colab after a built UI. |
…paste-pop-up-to-something-else-153
|
Is this still a draft PR? |
|
Made it to ready. Video is clicking copy paste multiple times. |
|
Added a note in the PR description: Note: This PR only affects UI, doesn't affect the copy paste behaviors in colab embedded view. The issue with colab embedded view is an common issue with <iframe> for security reasons |
|
sorry missed this PR. LGTM |
vutrung96
approved these changes
Dec 7, 2024
vutrung96
deleted the
CURATOR-48-curator-viewer-ux-change-the-copy-paste-pop-up-to-something-else-153
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed #153
Changes:
Testings:
Quick demo:
video
Note: This PR only affects UI, doesn't affect the copy paste behaviors in colab embedded view. The issue with colab embedded view is an common issue with <iframe> for security reasons.