Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curator-viewer] add time logging and curator viewer show distribution #149

Merged

Conversation

CharlieJCJ
Copy link
Contributor

@CharlieJCJ CharlieJCJ commented Nov 19, 2024

Changes:

New GenericResponse:

class GenericResponse(BaseModel):
    response_message: Optional[Dict[str, Any]] | str = None
    response_errors: Optional[List[str]] = None
    raw_response: Optional[Dict[str, Any]]
    raw_request: Optional[Dict[str, Any]] = None
    generic_request: GenericRequest
    created_at: datetime.datetime
    finished_at: datetime.datetime
Screen.Recording.2024-11-19.at.4.15.49.PM.mov
Screen.Recording.2024-11-19.at.2.05.59.PM.mov

Nice to have:

@CharlieJCJ CharlieJCJ changed the base branch from main to dev November 19, 2024 22:10
@CharlieJCJ CharlieJCJ changed the title Curator 43 add time logging and curator viewer show distribution [curator-viewer] add time logging and curator viewer show distribution Nov 19, 2024
@CharlieJCJ CharlieJCJ linked an issue Nov 19, 2024 that may be closed by this pull request
@CharlieJCJ CharlieJCJ marked this pull request as ready for review November 19, 2024 22:36
@CharlieJCJ CharlieJCJ requested a review from vutrung96 November 19, 2024 22:36
@CharlieJCJ CharlieJCJ marked this pull request as draft November 19, 2024 22:43
@CharlieJCJ
Copy link
Contributor Author

let me add one more view, which is the time series plot, that's useful for #141 comparison with OpenAIOnline

@CharlieJCJ CharlieJCJ marked this pull request as ready for review November 20, 2024 00:19
@CharlieJCJ
Copy link
Contributor Author

Ready for review @vutrung96 @RyanMarten

@vutrung96
Copy link
Contributor

Some errors I found:

Module not found: Can't resolve 'prismjs'
  1 | import { Button } from "@/components/ui/button";
  2 | import { Check, Copy } from "lucide-react";
> 3 | import Prism from 'prismjs';
    | ^
  4 | import 'prismjs/components/prism-python';
  5 | import 'prismjs/themes/prism-tomorrow.css';
  6 | import React from 'react';

https://nextjs.org/docs/messages/module-not-found
  1. security vulnerability
(bespokelabs-curator-py3.11) (base) trung@trung-cpu:~/curator/bespoke-dataset-viewer$ npm install

up to date, audited 580 packages in 6s

150 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
(bespokelabs-curator-py3.11) (base) trung@trung-cpu:~/curator/bespoke-dataset-viewer$ npm audit fix

changed 1 package, and audited 580 packages in 6s

150 packages are looking for funding
  run `npm fund` for details
  1. Some unique key error in Bespoke Curator Runs
    Screenshot 2024-11-19 at 7 46 55 PM

  2. NaNs when running camel.py??
    Screenshot 2024-11-19 at 7 49 22 PM

@CharlieJCJ
Copy link
Contributor Author

CharlieJCJ commented Nov 20, 2024

point1, 2 resolved.
point 3 addressed.
point 4 is due to not poetry shell during testing.


need to double check whether point3 is actually been resolved, can't reproduce the same setting from my end.

Copy link
Contributor

@vutrung96 vutrung96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm it works on my end and the graph looks beautiful. thank you @CharlieJCJ !

Copy link
Contributor

@vutrung96 vutrung96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-19 at 10 29 45 PM
actually one more issue, seems like text is off here (both lines say responses received)

@vutrung96 vutrung96 merged commit 72d2d68 into dev Nov 20, 2024
@vutrung96 vutrung96 deleted the CURATOR-43-add-time-logging-and-curator-viewer-show-distribution branch November 20, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants