Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LiteLLM+instructor (for structured output) backend for curator #141
Add LiteLLM+instructor (for structured output) backend for curator #141
Changes from 49 commits
a51716b
cbc8797
14a5dcc
7c4f82e
c8623cf
d72d917
959c005
db6ebef
3ef9cf6
feb042d
c8d5d05
a9c65a4
4f3437b
f755b73
f7be7e9
6e41905
973fca4
3e2eefa
e94ad4a
74e6375
4f0e1ce
e045cda
cddf820
56e2338
e571343
ad0fd1f
50053c9
3e843f8
8f25ed9
9065f55
2c80195
a8c547b
5c88363
4115176
80229e8
b0cae1f
b438e2c
50f631b
8a89204
10ea1f4
f834531
e62bd9d
52be211
cee80b0
f358210
f56d766
8dbf9e9
6fe5fd1
e261517
17766b5
adc04b4
b0e0f25
d272b59
a3a4d74
f9ae234
4ec368d
2831914
bd99464
0d5292d
87b58ea
e24d493
6d8da45
73b7ab4
29ad907
c56a5ed
f79226d
d9b3cf4
ec1a1e9
2ba4bdf
232dab5
50ee9e7
cdfe4a2
5cf2c7f
2e0ac2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to do now to give control and be able to test out our different backends, however @vutrung96 has made a good point that maybe we don't actually want to make this a choice that users know or think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's have this as None by default and have routing logic like we discussed.
if the user sets backend to "openai" or "litellm", then we'll respect their choices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see this routing logic below?
if i set my model to claude, i also need to set my backend to "litellm"?