Skip to content

Commit

Permalink
Merge pull request #468 from AlexKay85/master
Browse files Browse the repository at this point in the history
fix for broken pagination
  • Loading branch information
AlexKay85 authored Nov 19, 2020
2 parents 9883bc3 + 71462f1 commit 623d365
Show file tree
Hide file tree
Showing 13 changed files with 202 additions and 173 deletions.
18 changes: 16 additions & 2 deletions db_update.php
Original file line number Diff line number Diff line change
Expand Up @@ -378,15 +378,29 @@
closedir($handle);
}
}
if (version_compare($installedtag, $current_release_tag) < 0) {
echo 'module update berliSoftphones done <br>';
echo 'module update berliSoftphones done <br>';

if (version_compare($installedtag, $current_release_tag) < 0) {
echo 'Add INDEX to vtiger_email_track<br>';
$query = "ALTER TABLE `vtiger_email_track` ADD INDEX (`mailid`);";
$adb->pquery($query, array());
echo 'Adding INDEX done<br>';
}

echo 'module update berliWidgets start<br>';
$moduleInstance = Vtiger_Module::getInstance("berliWidgets");
if($moduleInstance) {
updateVtlibModule("berliWidgets", "packages/vtiger/mandatory/berliCleverReach.zip");
}
echo 'module update berliWidgets done<br>';

echo 'module update berliCleverReach start<br>';
$moduleInstance = Vtiger_Module::getInstance("berliCleverReach");
if($moduleInstance) {
updateVtlibModule("berliCleverReach", "packages/vtiger/optional/berliCleverReach.zip");
}
echo 'module update berliCleverReach done<br>';

$query = "UPDATE `vtiger_version` SET `tag_version` = ?";
$adb->pquery($query, array($current_release_tag));
echo "<h2>Finished updating to $current_release_tag!</h2>";
322 changes: 163 additions & 159 deletions layouts/vlayout/modules/Vtiger/dashboards/HistoryContents.tpl

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ Vtiger_Widget_Js('Vtiger_History_Widget_Js', {}, {
});
AppConnector.request(params).then(function(data){
refreshContainer.progressIndicator({'mode': 'hide'});
loadMoreHandler.replaceWith(data);
loadMoreHandler.parent().parent().replaceWith(data);
thisInstance.registerLoadMore();
}, function(){
refreshContainer.progressIndicator({'mode': 'hide'});
Expand Down
4 changes: 0 additions & 4 deletions modules/Vtiger/views/RelatedList.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ function process(Vtiger_Request $request) {
$viewer->assign('TOTAL_ENTRIES', $totalCount);
$viewer->assign('PERFORMANCE', true);
}
else {
$viewer->assign('PAGE_COUNT', '1');
$viewer->assign('PERFORMANCE', false);
}

$viewer->assign('MODULE', $moduleName);
$viewer->assign('PAGING', $pagingModel);
Expand Down
Binary file modified packages/vtiger/mandatory/berliWidgets.zip
Binary file not shown.
Binary file modified packages/vtiger/optional/berliCleverReach.zip
Binary file not shown.
4 changes: 2 additions & 2 deletions pkg/vtiger/modules/berliCleverReach/manifest.xml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?xml version='1.0'?>
<module>
<exporttime>2019-10-08 13:43:08</exporttime>
<exporttime>2020-11-18 07:43:08</exporttime>
<name>berliCleverReach</name>
<label>CleverReach</label>
<parent>Marketing</parent>
<version>0.95</version>
<version>0.96</version>
<dependencies>
<vtiger_version>6.5.0</vtiger_version>
<vtiger_max_version>6.*</vtiger_max_version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ public function createCleverReachAttributes() {
// creating attributes for the first time can take MINUTES after an successful API request
foreach ($fieldsneeded as $fieldname => $fieldtype) {
if (isset($tmpfields[$fieldname]) && $tmpfields[$fieldname] != $fieldtype) {
throw new Exception('{"status":"error","message":"Cannot change type of attribute $fieldname to $fieldtype"}');
}
throw new Exception('{"status":"error","message":"Cannot change type of attribute '.$fieldname.' to '.$fieldtype.'"}');
}
else {
$newfield = array("name"=>$fieldname, "type"=>$fieldtype);
$this->rest->post("/attributes", $newfield);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
'berliWidgets' => 'berliWidgets',
'LBL_RELATED_TO' => 'bezogen auf',
'LBL_NO_RECORDS' => 'keine Daten',

'LBL_WRITE_ACCESS_FOR' => 'Sie haben keine Erstellrechte für ',
'LBL_MODULE_DENIED' => 'Der Modulzugang ist gesperrt.',
'LBL_PROBLEM_UPLOAD' => 'Es gab ein Update Problem, bitte die Seite neu laden und nochmal versuchen.',
);

?>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
'berliWidgets' => 'berliWidgets',
'LBL_RELATED_TO' => 'related to',
'LBL_NO_RECORDS' => 'no data',

'LBL_WRITE_ACCESS_FOR' => 'You do not have create privileges for ',
'LBL_MODULE_DENIED' => 'The module access is denied.',
'LBL_PROBLEM_UPLOAD' => 'There has been an upload problem. Please reload the page an try again.',
);

?>
2 changes: 1 addition & 1 deletion pkg/vtiger/modules/berliWidgets/manifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<label>berliWidgets</label>
<parent></parent>
<type>extension</type>
<version>1.0.0</version>
<version>1.0.1</version>
<dependencies>
<vtiger_version>6.5.0</vtiger_version>
<vtiger_max_version>6.*</vtiger_max_version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public function checkPermission(Vtiger_Request $request) {
}

public function process(Vtiger_Request $request) {
global $currentModule;
$db = PearDatabase::getInstance();
$current_user = Users_Record_Model::getCurrentUserModel();
$parentid = $request->get('recordid');
Expand Down
10 changes: 10 additions & 0 deletions vtlib/tools/console.php
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,16 @@ protected function create($moduleInformation) {
$field4->displaytype= 2;
$block->addField($field4);

$field5 = new Vtiger_Field();
$field5->name = 'modifiedby';
$field5->label= 'Last Modified By';
$field5->table = 'vtiger_crmentity';
$field5->column = 'modifiedby';
$field5->uitype = 52;
$field5->typeofdata = 'V~O';
$field5->displaytype= 3;
$block->addField($field5);

// Create default custom filter (mandatory)
$filter1 = new Vtiger_Filter();
$filter1->name = 'All';
Expand Down

0 comments on commit 623d365

Please sign in to comment.