-
Notifications
You must be signed in to change notification settings - Fork 2
Use in-workflow MCP server via in-memory transport #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dandavison
wants to merge
2
commits into
bergundy:main
Choose a base branch
from
dandavison:workflow-mcp-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| from temporalio import workflow | ||
| import temporalio.workflow | ||
|
|
||
| with temporalio.workflow.unsafe.imports_passed_through(): | ||
| from nexusmcp import workflow | ||
|
|
||
| with workflow.unsafe.imports_passed_through(): | ||
| from .inbound_gateway import InboundGateway | ||
| from .service import MCPService | ||
| from .service_handler import MCPServiceHandler, exclude | ||
| from .workflow_transport import WorkflowTransport | ||
|
|
||
| __all__ = ["MCPService", "MCPServiceHandler", "InboundGateway", "exclude", "WorkflowTransport"] | ||
| __all__ = ["MCPService", "MCPServiceHandler", "InboundGateway", "exclude", "workflow"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from .mcp_client import MCPClient | ||
|
|
||
| __all__ = ["MCPClient"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| from contextlib import asynccontextmanager | ||
| from typing import Any, AsyncGenerator | ||
|
|
||
| import mcp.types as types | ||
| from mcp.client.session import ClientSession | ||
| from mcp.server.lowlevel import Server | ||
| from mcp.shared.memory import create_connected_server_and_client_session | ||
| from temporalio import workflow | ||
|
|
||
| from nexusmcp.service import MCPService | ||
|
|
||
|
|
||
| class MCPClient: | ||
| """ | ||
| An MCP client for use in Temporal workflows. | ||
|
|
||
| This class provides a client that proxies MCP traffic from a Temporal Workflow to a Temporal | ||
| Nexus service. It works by running an MCP server in the workflow whose handlers delegate to | ||
| nexus operations, and connecting to it via an in-memory transport. | ||
|
|
||
| Example: | ||
| ```python | ||
| client = MCPClient("my-endpoint") | ||
| async with client.connect() as session: | ||
| await session.list_tools() | ||
| await session.call_tool("my-service_my-operation", {"arg": "value"}) | ||
| ``` | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| endpoint: str, | ||
| ): | ||
| self.endpoint = endpoint | ||
| # Run an in-workflow MCP server whose handlers make nexus calls | ||
| self.mcp_server = Server("workflow-gateway-mcp-server") | ||
| self.mcp_server.list_tools()(self._handle_list_tools) # type: ignore[no-untyped-call] | ||
| self.mcp_server.call_tool()(self._handle_call_tool) | ||
|
|
||
| @asynccontextmanager | ||
| async def connect(self) -> AsyncGenerator[ClientSession, None]: | ||
| """ | ||
| Create a connected MCP ClientSession. | ||
|
|
||
| The session is automatically initialized before being yielded. | ||
| """ | ||
| async with create_connected_server_and_client_session( | ||
| self.mcp_server, | ||
| raise_exceptions=True, | ||
| ) as session: | ||
| yield session | ||
|
|
||
| async def _handle_list_tools(self) -> list[types.Tool]: | ||
| nexus_client = workflow.create_nexus_client( | ||
| endpoint=self.endpoint, | ||
| service=MCPService, | ||
| ) | ||
| return await nexus_client.execute_operation(MCPService.list_tools, None) | ||
|
|
||
| async def _handle_call_tool(self, name: str, arguments: dict[str, Any]) -> Any: | ||
| service, _, operation = name.partition("_") | ||
| nexus_client = workflow.create_nexus_client( | ||
| endpoint=self.endpoint, | ||
| service=service, | ||
| ) | ||
| return await nexus_client.execute_operation(operation, arguments) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would go into the Temporal SDK eventually.