Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

change is not implemented#200

Open
uwej711 wants to merge 1 commit into
bergie:masterfrom
uwej711:change
Open

change is not implemented#200
uwej711 wants to merge 1 commit into
bergie:masterfrom
uwej711:change

Conversation

@uwej711

@uwej711 uwej711 commented Dec 18, 2013

Copy link
Copy Markdown
Contributor

Not sure but this looks like a backbone change ...

@dbu

dbu commented Apr 17, 2014

Copy link
Copy Markdown

@bergie looks like the travis setup with saucelabs is broken... could you investigate?

@bergie

bergie commented Jan 19, 2015

Copy link
Copy Markdown
Owner

@dbu travis setup is fixed now

@dbu

dbu commented Jan 21, 2015

Copy link
Copy Markdown

@bergie great. can you click on the failed build link and restart the build so we can see if this works? and review the PR and merge if its good?

@bergie

bergie commented Jan 21, 2015

Copy link
Copy Markdown
Owner

@dbu did you rebase? The build fixes are only in master

@uwej711

uwej711 commented Jan 21, 2015

Copy link
Copy Markdown
Contributor Author

Rebased

@dbu

dbu commented Jan 21, 2015

Copy link
Copy Markdown

strange. this still stops at a build error, but travis says that the master is building correctly. @uwej711 can you re-check if you have everything from upstream master?

@uwej711

uwej711 commented Jan 21, 2015

Copy link
Copy Markdown
Contributor Author

Checked, the only difference I see doing git diff origin/master uwej711/change is the same as here ...

@dbu

dbu commented Jan 21, 2015

Copy link
Copy Markdown

@bergie any idea what is causing the problem on travis then?

@bergie

bergie commented Jan 21, 2015

Copy link
Copy Markdown
Owner

@dbu @uwej711 well, the latest fails with Bower trying to install rangy: https://travis-ci.org/bergie/create#L231

Checking that, it seems this is now replaced by rangy-official

@bergie

bergie commented Jan 22, 2015

Copy link
Copy Markdown
Owner

@dbu @uwej711 builds are passing now on master again, please rebase

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants