feat: debugger image configurable

bentoml · Dec 20, 2022 · ec113ce · ec113ce
1 parent e28305c
commit ec113ce
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/api-server/controllers/controllersv1/terminal.go b/api-server/controllers/controllersv1/terminal.go
@@ -6,6 +6,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"os"
 	"time"
 
 	"github.com/gin-gonic/gin"
@@ -279,9 +280,14 @@ func (t *WebTerminal) Safe(fn func() error) error {
 }
 
 func (t *WebTerminal) HandleDebug(ctx context.Context, cliset *kubernetes.Clientset, restConfig *rest.Config) error {
+	debuggerImage := "quay.io/bentoml/bento-debugger:0.0.6"
+	debuggerImage_ := os.Getenv("INTERNAL_IMAGES_DEBUGGER")
+	if debuggerImage_ != "" {
+		debuggerImage = debuggerImage_
+	}
 	o := DebugOptions{
 		Args:            []string{"bash"},
-		Image:           "quay.io/bentoml/bento-debugger:0.0.5",
+		Image:           debuggerImage,
 		Interactive:     true,
 		TTY:             true,
 		Namespace:       t.pod.Namespace,

diff --git a/helm/yatai/templates/secret-env.yaml b/helm/yatai/templates/secret-env.yaml
@@ -30,3 +30,5 @@ stringData:
   {{- end }}
 
   TRANSMISSION_STRATEGY: {{ .Values.transmissionStrategy | quote }}
+
+  INTERNAL_IMAGES_DEBUGGER: {{ .Values.internalImages.debugger | quote }}
diff --git a/helm/yatai/values.yaml b/helm/yatai/values.yaml
@@ -108,3 +108,6 @@ enableHostTimeZone: false
 
 transmissionStrategy: proxy
 doNotTrack: false
+
+internalImages:
+  debugger: quay.io/bentoml/bento-debugger:0.0.6