Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add property configFiles to API #19

Merged
merged 1 commit into from
May 4, 2024

Conversation

mikebaum
Copy link
Contributor

@mikebaum mikebaum commented May 4, 2024

As per the discussion started in #18 this is an initial PR to add a configFiles property to the Pipeline API.

The configFiles can be used to specify additional configuration to mount as files in the config directory. This new property is needed in cases where the provided benthos configuration may need to read a file in order to perform its work. This is not intended for secrets.

Copy link
Member

@mfamador mfamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mfamador mfamador merged commit f4e4748 into benthosdev:main May 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants