fix: handle empty proxy environment variables #779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When proxy environment variables (
http_proxy,https_proxy, etc.) are set to empty strings or whitespace-only values, hackney crashes with a pattern match error inhackney_url:parse_netloc/2.Problem
export http_proxy=""causes all hackney requests to failSolution
do_get_proxy_env/1before attempting to parseTest plan
test/hackney_proxy_tests.erl-DTESTflag