Fix default ssl options in presence of SNI #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savonarola
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes SSL certificate verification when Server Name Indication (SNI) is used. The change ensures that when SNI is specified in the SSL options, the certificate is verified against the SNI hostname rather than the connection hostname.
- Updates
merge_ssl_opts/2to determine the correct hostname for certificate verification based on SNI configuration - Extracts the SNI value from override options and uses it as the verification host when SNI is enabled
Comments suppressed due to low confidence (1)
src/hackney_connection.erl:140
- [nitpick] The variable name 'SNI' is an acronym that could be more descriptive. Consider renaming it to 'SniHostname' or 'SniValue' to better indicate that it represents the hostname value for SNI.
SNI -> SNI
Owner
|
thznk you for your change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
If
server_name_indicationis passed, then the server provides us the appropriate certificate. So we need to match the passed SNI value with the certificate, not the connect host.