assert only, no change intended: never reflect invalid input #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not even in error reponses!
(Binding precedence of *not*) is not beneficial to readability.
pajod
force-pushed
the
patch-refuse-xss
branch
from
a7efba4 to
5194854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix any bug, nor does it add any feature.
But if my less obviously correct patch for #3125 that deletes all the duplicate branches in error handling is flawed, then adding this assertion should reduce the impact of bugs from somewhat worrying "reflected injection" to much less worrying "crashes with proper traceback".
EDIT: No, those are not
superfluous-parens. (Using the binding precedence ofnot)is notproducing readable code. I recommend disabling that pylint warning