Added missing prefillParallelism argument in redis.go newRedisPool function #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @benmanns / @TheOrioli / @brockwood, |
oprearocks
reviewed
Feb 14, 2020
goworker.go
Outdated
| UseNumber bool | ||
| SkipTLSVerify bool | ||
| TLSCertPath string | ||
| prefillParallelism int |
There was a problem hiding this comment.
Is it okay to use camelCase here? In the README you are using PascalCase.
There was a problem hiding this comment.
Thanks for pointing, fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were major changes in see history. The changes on May 25th, 2019 broken goworker package. Added required parameter with default value ( default value 0 as defined in struct ) to fix the issue
This PR will fix an open issue #76