Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move index field declarations to a configurable base class #16

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

move index field declarations to a configurable base class #16

wants to merge 2 commits into from

Conversation

xmedia-systems
Copy link

Fix for #15

@beniwohli
Copy link
Owner

Awesome, thanks!

There's a bit of a backwards-compatibility problem with this patch, though: if you already defined a custom base class for the index, you will loose all the fields currently defined on _PageIndex. I'm not sure how this could be solved. Emit a warning if the custom base class doesn't have the necessary fields perhaps?

Kind Regards,
Benjamin

@xmedia-systems
Copy link
Author

Yes, you're right!

This check makes sense anyway. I've just updated my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmedia-systems @beniwohli