Fix number formatting on non-64bit architectures #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-race is not supported when running tests on Linux/386.
|
Thanks @guilherme-puida. That was a good start. I've updated the PR with a bunch more similar fixes, and tweaked the CI. I'll merge shortly. |
|
Thanks, sorry for missing the other places :^) |
|
No problems, and thanks for the initial PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the correct approach, but it looks fine. I also added Linux/386 tests on CI, but I don't know if you actually want this. I figured it would make it easier to verify that it works.
Closes #234