flushAll() stops flushing on first error #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The && operator causes conditional evaluation (aka "short-circuiting"). This means if the left-hand-side is false the right hand side is not evaluated. If any call to interp.flushWriter returns false then all streams following that stream in the range, as well as interp.output, will not be flushed. Removes the type cast to the flusher interface because that is done in interp.flushWriter. This check would be performed twice for any interp.output value whose type implements the interface. Fixes benhoyt#208
|
Let me know if you want me to add regression tests. |
|
Good catch. This looks excellent. I think it's tough to test (even with a white-box test), so let's just leave as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The && operator causes conditional evaluation (aka "short-circuiting"). This means if the left-hand-side is false the right hand side is not evaluated. If any call to interp.flushWriter returns false then all streams following that stream in the range, as well as interp.output, will not be flushed.
Removes the type cast to the flusher interface because that is done in interp.flushWriter. This check would be performed twice for any interp.output value whose type implements the interface.
Fixes #208