Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conflict with non-compatible versions of nikic/php-parser. #68

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

rodrigoaguilera
Copy link
Collaborator

Bump psy/psysh to allow for nikic/php-parser v5.

Following up on the error from github actions
https://github.com/beluga-php/docker-php/actions/runs/7960004992/job/21769598590

I arrived with a google search to a similar error
sebastianbergmann/phpcov#113

One of the solutions was to bump nikic/php-parser so let's just do that sebastianbergmann/php-code-coverage@347a87a

it is strange that "prefer-lowest" is picking php-parser 4.10 since the requirements are at least for 4.18 🤷
This is the output of composer why nikic/php-parser

phpunit/php-code-coverage 9.2.30     requires  nikic/php-parser (^4.18 || ^5.0) 
psy/psysh                 v0.11.22   requires  nikic/php-parser (^4.0 || ^3.1)  
sebastian/complexity      2.0.3      requires  nikic/php-parser (^4.18 || ^5.0) 
sebastian/lines-of-code   1.0.4      requires  nikic/php-parser (^4.18 || ^5.0) 

For this reason I'm also bumping psysh, so the v5 of the parser can be installed.

Bump psy/psysh to allow for nikic/php-parser v5.
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@flavioheleno flavioheleno merged commit e2d4ec3 into beluga-php:master Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants