New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusing with frozen slack account #7

Open

belltailjp wants to merge 2 commits into master from fix-confusing-with-frozen-slack-account

Owner

belltailjp commented Aug 2, 2019

The current slack notification (mention after the training finishes) had two problems.

In case there are multiple users that have the same display name
- This happens when only one user is active and others are already deactivated
Display Name vs Name
- The current implementation looked at only "name"
- But on Slack client, when sending a mension we use display name instead
  - So it is natural to use display name in chainer_slack_report too

This PR fixes both of them.

TODO: There is a case where display name becomes empty, although we can send mention using (apparently) real_name? Need to check

belltailjp added 2 commits

August 2, 2019 13:38


          Ignore already deactivated slack users

3d50ec9


          Use .profile.display_name instead of .name for consistency with slack…

b7b48bf

… behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet